search

mxstbr / login-flow

:key: A login/register flow built with React&Redux
https://loginflow.mxstbr.com
MIT License
1.6k stars 215 forks source link

Why not onEnter in the route path #5

Closed weblancaster closed 8 years ago

weblancaster commented 8 years ago

Hi @mxstbr thanks for sharing this repo I got say was a big time consuming to find the best way to do a login flow so I'm sure this repo will be very useful for a lot of people.

In this case we can use onEnter which will remove the logic from component dashboard that way we keeping it more clean.

let me know your thoughts.

mxstbr commented 8 years ago

That sounds like a very good idea to be honest, I'd love a PR!

EDIT: Also, thanks for the compliments, really glad it's useful!