search

mxstbr / login-flow

:key: A login/register flow built with React&Redux
https://loginflow.mxstbr.com
MIT License
1.6k stars 215 forks source link

update some packages to latest version, remove deprecated dependency... closes #5 #6

Closed weblancaster closed 8 years ago

weblancaster commented 8 years ago

update some packages to latest version, remove deprecated dependency improve routing auth flow adding onEnter and checkAuth method. closes #5

mxstbr commented 8 years ago

Thanks so much, I'll check it out soon!

mxstbr commented 8 years ago

A few nitpicks here and there, but other than that it looks great! Could you fix those and then I'll merge.

Thanks so much!

weblancaster commented 8 years ago

@mxstbr it's moved.. just one thing I can't get to access the store from the checkAuth you can see that the way I have at the moment is creating a new instance which isn't what we want.. any thoughts on that? one of the reasons I kept on the same file (on my personal project).

I also added sourcemap/devtools to webpack to be able to debug the files easier.

mxstbr commented 8 years ago

Interesting, that's indeed a problem. Maybe that was a mistake, would you mind reverting that change and putting both of those functions into the app.js again? Thanks and sorry for the troubles!

What does sourcemap/devtools do?

weblancaster commented 8 years ago

Done @mxstbr no problem.

mxstbr commented 8 years ago

Thanks so much @weblancaster, great work!