search

mxstbr / passport-magic-login

Passwordless authentication with magic links for Passport.js.
MIT License
664 stars 45 forks source link

feat: support threading request into verify method #12

Closed rfbowen closed 2 years ago

rfbowen commented 2 years ago

Hi Max!

First, I love that you're actively maintaining this and providing so much value to folks. This is a very concise and clean implementation of magic links and I really appreciate you capturing it in this package.

I've grown rather fond of being able to access the request in the verify callback - a feature I've encountered in some other passport libraries (https://github.com/jaredhanson/passport-google-oauth2). I was going to file a feature request, but thought it better to come with the solution along with the request.

Let me know if this solution seems an appealing or reasonable one to you, or if this feature is unwelcome in your library. I tried to keep it minimal and non-breaking. Your time and consideration are valued regardless!

Reno

mxstbr commented 2 years ago

Published in v1.0.9! Thanks again.