Housekeeping - Githubissues

mxstbr / passport-magic-login

Passwordless authentication with magic links for Passport.js.

MIT License

664 stars 45 forks source link

Housekeeping #4

Closed tmkn closed 3 years ago

tmkn commented 3 years ago

This PR includes some code cleanup

remove passport-strategy dependency as it doesn't provide anything useful
reuse types from passport/express
convert MagicLoginStrategy to use the class keyword for better type safety (no declare class needed)
simplified the constructor by removing unused assignments, using arrow functions instead of .bind(this) and TypeScript's constructor assignments

Overall this removes around 20 lines of unnecessary typings, however I didn't test the changes with a working project. Tests pass though.