Closed JackCA closed 3 years ago
prettier 1.* does not support typescript 3.8's type imports so the following error would occur when prettier was run:
1.*
["ERROR" - 3:43:40 PM] '=' expected. (1:13) > 1 | import type { Request, Response } from 'express';
This is also what's causing the current CI failure.
tsdx has not upgraded to prettier 2.* yet so we cannot use type imports yet.
2.*
See https://github.com/formium/tsdx/pull/632 and https://github.com/prettier/prettier/issues/7263
This doesn't seem to have any impact on build size.
Since prettier works now, there are other prettier-related fixes in this PR.
Thank you!!
prettier
1.*
does not support typescript 3.8's type imports so the following error would occur when prettier was run:This is also what's causing the current CI failure.
tsdx has not upgraded to prettier
2.*
yet so we cannot use type imports yet.See https://github.com/formium/tsdx/pull/632 and https://github.com/prettier/prettier/issues/7263
This doesn't seem to have any impact on build size.
Since prettier works now, there are other prettier-related fixes in this PR.