search

mxstbr / sharingbuttons.io

Quickly generate social sharing buttons with a tiny performance footprint
http://sharingbuttons.io
MIT License
2.48k stars 103 forks source link

Whatsapp icon is all white in solid circle mode #63

Closed siddharthkp closed 7 years ago

siddharthkp commented 7 years ago

Check out this share button - The whatsapp icon is all white.

screen shot 2016-09-22 at 8 54 12 pm

This is because the whatsapp logo has white instead of transparent. Compare it with the twitter logo.

screen shot 2016-09-22 at 8 59 44 pm screen shot 2016-09-22 at 9 00 01 pm

Digging deeper, it seems the way it is structured. The whatsapp logo has an extra white path on it.

screen shot 2016-09-22 at 9 05 07 pm screen shot 2016-09-22 at 9 05 38 pm

There are two things I can think of -

  1. Make another svg which only is only made of black strokes leaving the icon in transparent. (Sorry, I can't help you with that)
  2. Use a png instead.

@mxstbr, What do you think?

mxstbr commented 7 years ago

Definitely want to stick with SVG, I'd much rather edit the SVG to make this work. Not an expert myself though.

(@una mentioned on Twitter about looking for open source projects to contribute to, this might be a good first bug?)

siddharthkp commented 7 years ago

@mxsbtr, that's how I landed here :smile: Not sure if this is a beginner's bug though, you need some svg wizardry

siddharthkp commented 7 years ago

But, maybe I can source it from somewhere. Self assigning.