search

mxstbr / sharingbuttons.io

Quickly generate social sharing buttons with a tiny performance footprint
http://sharingbuttons.io
MIT License
2.48k stars 104 forks source link

62 feature wechat share #67

Open Enzuo opened 8 years ago

Enzuo commented 8 years ago

Hello

I added a Wechat share button as requested in issue #62. The principle is a bit different than others share buttons as there is no Wechat web app for sharing. The share button just displays a QR code so the user can open the website with Wechat on their mobile and share it from there.

mxstbr commented 8 years ago

That's definitely interesting! Is a QR code the way people share things to wechat?

Apart from that, I'm not a fan of the show-on-hover – I'd prefer if it showed-on-click and didn't open a new tab at all. Maybe with a checkbox hack?

Enzuo commented 8 years ago

I tried the checkbox magic 😉 and did some SVG optimisation

mxstbr commented 8 years ago

Hah, that's awesome, this is getting good! What about making the popup nicer, is there any easy wins styling-wise to not just make it a huge QR code?

Enzuo commented 8 years ago

I tried to reorganise the react components to fit the QR code in more nicely. Tell me if it seems ok to you :)