mxstbr
commented
7 years ago This looks great! 👏
One tiny thing, embedding the VK share script actually does 3 requests and fetches 6.3kb. Could you update those values?
I tested this by creating a index.html file with these contents:
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Test</title>
<!-- Put this script tag to the <head> of your page -->
<script type="text/javascript" src="https://vk.com/js/api/share.js?94" charset="windows-1251"></script>
</head>
<body>
<!-- Put this script tag to the place, where the Share button will be -->
<script type="text/javascript"><!--
document.write(VK.Share.button(false,{type: "round", text: "Share"}));
--></script>
</body>
</html>(this was just copied from the VK share button site above)
This is what I see in the DevTools network tab:
As you can see it loads the script itself, which injects another script tag into the HEAD and fetches an image. All together that's three requests that weigh 6.3kb!
richardwestenra
aghh1504
fixes #46 Also added new line character to Whatsapp SVG section.