search

mxstbr / sharingbuttons.io

Quickly generate social sharing buttons with a tiny performance footprint
http://sharingbuttons.io
MIT License
2.48k stars 103 forks source link

Pinterest still not working properly - Requires URL and Image #78

Open mrnagy88 opened 7 years ago

mrnagy88 commented 7 years ago

I'm not sure if this was intentional behaviour of the Pinterest Button:

https://blog.hubspot.com/hs-fs/hub/53/file-2622457892-png/Zappos_tool.png?t=1484158394658&width=545&name=Zappos_tool.png

If you see there the parameters for pinterest are ?url=[URLHere]&media=[ImageURLtoShareHere]&description=[DescriptionFromYourToolGoesHere]

Currently the Media parameter and URL parameter both have the site's URL in it, so when we try to share with Pinterest button we don't get an image, which is the whole point of pinterest.

I didn't have time to check the problem until now any most of my sites now have this broken pinterest button on them. I don't mind manually fixing it now that I know about it, but it might be worth letting us paste in an image URL from our site before generating the code.

I tried leaving it blank to see if Pinterest has the ability to let you choose an image manually if media is blank but it didn't work, there probably is a way to do that as well which would be a better placeholder if anyone can figure it out.

Thanks!

mrnagy88 commented 7 years ago

Basically, we need an image URL input field build into the sharingbuttons.io site so it adds a media file for Pinterest to work properly.