search

mxstbr / sharingbuttons.io

Quickly generate social sharing buttons with a tiny performance footprint
http://sharingbuttons.io
MIT License
2.48k stars 104 forks source link

Have the logos be a sprite or font-based #84

Closed bfad closed 5 years ago

bfad commented 7 years ago

I think it would be beneficial to have the logos be in a single sprite image or a single font. It would add an extra HTTP request, but at least it would be cacheable. Subsequent requests wouldn't have to make the additional request, and since the SVG code isn't inline, that means a reduction in bandwidth on those requests as well.

bfad commented 7 years ago

Or, maybe move the SVG data into a CSS background-image: url("data:image/svg+xml;...) since the CSS will be cached?

sparr commented 5 years ago

Is this still relevant? SVG appears to be inline now.

mxstbr commented 5 years ago

I think this is out of the scope of this project, as it is a small enhancement that might or might not work out as a benefit when tested with your actual production users. Will close this for now, thanks for starting this discussion @bfad!