search

mxstbr / sharingbuttons.io

Quickly generate social sharing buttons with a tiny performance footprint
http://sharingbuttons.io
MIT License
2.48k stars 104 forks source link

Facebook Link is 301 re-directing #87

Open mrnagy88 opened 6 years ago

mrnagy88 commented 6 years ago

This may affect SEO of sites since 301 re-direct could be considered an error or bad site design: <!-- Sharingbutton Facebook --> <a class="resp-sharing-button__link" href="https://facebook.com/sharer/sharer.php?u=[URLHERE]">

Should have www in front of it except in lowercase as below:

<!-- Sharingbutton Facebook --> <a class="resp-sharing-button__link" href="https://WWW.facebook.com/sharer/sharer.php?u=[URLHERE]">

Small change but it gets picked up by seo tools,

Also still have the issue I mentioned before about Pinterest requiring a "media file" which links to an image, would be nice to ask us what image to link to instead of just creating a broken Pinterest link.

Thanks! I will try to do pull request later but I'm not sure if I can as it would be my first. Daniel

sparr commented 5 years ago

This sounds like it would be an excellent first pull request for a new developer.

Re Pinterest, it is frowned upon to mix two different concerns into the same issue.