search

mxswat / mx-division-builds

A tool to create and share build easily currently in public beta
https://mxswat.github.io/mx-division-builds/
Other
83 stars 35 forks source link

Total Armor and Armor on Kill #105

Open AnibalDuarte opened 1 year ago

AnibalDuarte commented 1 year ago

I'm working on build this: https://mxswat.github.io/mx-division-builds/#/EwTgtMYAxgjGAWacCsYBszYA4QGY0YjkiAuFQrROPGWSu3AiLAdig7pNOxbxaTp4sdpwxxIOfAxLdY-SF2L1xxNbKikEMRXFkrM6o9FJ5wu+MrSGNtzcDy94IVqmEp+9SSiQgAdGgqsJL2eK6QwPC8wNY2sHSBIaSw6DYgusaw8KwBcJqsQA

I've find out that the "Total Armor" amount isn't counted properly the total amount nor the total core's count.

"Armor on Kill" isn't beign properly calculated for armor bonuses as Hunter's Fury and System Corruption. When used in combination with Ninjabike Backpack you can reach 35% + the "Armor on Kill" bonuses. I think the fields of "Armor on Kill" and "Armor on Kill %" should be calculated based on the final result of:

AoK% = Math.floor( ( BaseAoK / TotalArmor ) 100 ) TotalAoK = ( ( AoK% TotalArmor ) / 100 )

wkrick commented 1 year ago

I think that the stats on the right side are literally just the values you get from your gear broken out into different categories.

15 + 20 = 35 so it displays 35% on the right side in the "Armor on Kill %" category. So think that one is working as designed.

Likewise, I think the other value is just displaying the total amount of AoK (not percent) you get from your gear mods...

Armor on Kill: 56,805

It definitely seems like we need to come up with a way to display the combined value to make it more useful.

Unfortunately, I think a similar situation exists with Skill Efficiency. For example, if you equip 3 pieces of Empress, you get a bonus of 10% Skill Efficiency. That is equal to...

...but the builder doesn't show any of that either. The same applies to Weapon Handling.

But your request for an enhancement is definitely noted and we'll add it to the list.

THATDONFC commented 1 year ago

I'd like to add to this issue rather than create a new one. I noticed the Hazard Protection and individual status resistances don't display as they would in game.

For example, if I want to build for 100% Shock Resist and have 80% Haz Pro, adding 2 Electrique for the 20% shock resist brand set bonus should give me 100% shock resist. The tool currently shows 20% shock resist but in game I would see 100% shock resist.