Closed ba58smith closed 5 years ago
Update: I think that some esp32 boards define LED_BUILTIN and some don't. So, looks like we need something like this, in config.h, maybe? Or does it need to be one of the last #includes in sigksens.ino, so that it will be user-defined only if it's not been defined by the particular board? (I don't know where the specific board's #define statements come in, but this one should be after that, I believe.)
#ifndef LED_BUILTIN
#define LED_BUILTIN 13 // pin number is specific to your esp32 board
#endif
Well, that won't work, at least for my Heltec Wifi Kit 32 with the built-in screen. It has this in one of its board definition files: static const uint8_t LED_BUILTIN = 25;
. So I can't #define LED_BUILTIN x
because I guess #ifndef doesn't know that LED_BUILTIN has already been used as a constant variable. Is there another way for me to detect that LED_BUILTIN has already been used, but not with a #define?
merged #69 :) That works fine :)
Thanks!
From my summary of the getting SigkSens to work with ESP32:
I didn't see that anyone fixed this, so it's still an issue, I think.