my-cloud / ruthenium

Golang implementation of the Ruthenium protocol
The Unlicense
11 stars 1 forks source link

chore(ui): move templates folder #175

Closed WendyTP closed 1 year ago

WendyTP commented 1 year ago

Checklist:

WendyTP commented 1 year ago

@JeremyPansier : Can you please check this pull request?

JeremyPansier commented 1 year ago

@JeremyPansier : Can you please check this pull request?

Sure! Thank you so much for contributing to Ruthenium!

JeremyPansier commented 1 year ago
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

WendyTP commented 1 year ago

The container has been built and tested. The pull request title is also changed.

WendyTP commented 1 year ago

By the way, the README file contains misleading docker run parameters. https://github.com/my-cloud/ruthenium/blob/main/README.md?plain=1#L51-L55

JeremyPansier commented 1 year ago

By the way, the README file contains misleading docker run parameters. https://github.com/my-cloud/ruthenium/blob/main/README.md?plain=1#L51-L55

You are right, the -host-ip parameter for the node docker image is obsolete. I just created this issue to fix it.