search

my-dao-dashboard / My-DAO-Dashboard

My DAO Dashboard
https://www.mydaodashboard.com
Apache License 2.0
23 stars 7 forks source link

Returned values aren't valid - with new Aragon DAO #1

Closed wslyvh closed 5 years ago

wslyvh commented 5 years ago

Describe the issue Getting errors when trying to retrieve a newly created Aragon DAO; Returned values aren't valid. Possibly related to v0.8 Aragon upgrade. OR because of different voting (e.g. Kernel, ACL) types. Right now we only parse Minting or Token types.

Steps to Reproduce

  1. Go to the dashboard, with any account.
  2. In settings; Add the following address: 0x3917d5Db38879BAb97Cb5B65eC5562F4CF648196
  3. Go back to the dashboard & refresh.

Expected behavior Should show the overview of your DAO's.

Actual behavior Dashboard remains stuck at "Loading DAO's..". But an error is shown on the console window.

Environment

Additional data

image

wslyvh commented 5 years ago

This was not related to any Aragon App - or upgrades.

But by querying each token from the account balance, to check if it is an Aragon DAO. Some tokens seem incompatible. Need to further debug this, but for now, just skipping the 'invalid' tokens.

ukstv commented 5 years ago

Some of the tokens naively considered as Aragon ones are really something else. The one mentioned above is District0x, for example. Try-catch approach seems perfectly valid here. Gonna beautify it a bit. This should be done anyway, as current dao service thing is copied mainly from quick and dirty hackathon times.