search

my-koop / module.user

User module for My Koop responsible for user profiles
GNU General Public License v2.0
0 stars 0 forks source link

Validation for update profile #70

Closed logiad closed 9 years ago

logiad commented 9 years ago

Update profile validation with a list of localised validation messages at the top of the component and highlighting of erroneous fields Selected value in dropdowns is also verified, if someone tries to sneak in their own value, validation will catch it. *Note: This doesn't make use of the i18n library, but since this validation is functionnal, no futher time will be spent on it. At some point, change should be done to ensure uniformity. updateprofilevalidation

Cellule commented 9 years ago

You need to attach the validation in the backend also, actually the backend is more important than the frontend version https://github.com/my-koop/module.user/blob/final/lib/controllers/index.ts#L109

logiad commented 9 years ago

changes done.

Cellule commented 9 years ago

please merge before review

logiad commented 9 years ago

Merged.

Cellule commented 9 years ago

Good to merge