my-ugly-code / WebsUpTV

Node.js application for displaying various web widgets over Android TV OS - Sports, News, Weather, Plex and more
25 stars 2 forks source link

Hardcoded URL in plex.js #6

Closed JamynShanley closed 1 year ago

JamynShanley commented 1 year ago

https://github.com/my-ugly-code/WebsUpTV/blob/65b4ba7f9f31f5b3af4cda1f255e0776e5c51e09/services/plex.js#L72

Perhaps this should be updated to use a variable.

my-ugly-code commented 1 year ago

@JamynShanley You're 100% right. I'll get this changed now. Thanks so much for letting me know!

my-ugly-code commented 1 year ago

On further inspection, the pipUrl field was a remnant of an older solution, which used the actual PMS details page instead of the node-hosted page. I've removed the unused field and pushed a new version of plex.js to the repo. Users do not need to update, but this will keep future changes cleaner. Thanks again, marking this as closed. https://github.com/my-ugly-code/WebsUpTV/commit/4429ea3231812acd05ed859a17fd6fcc67bf8748