search

my8100 / logparser

A tool for parsing Scrapy log files periodically and incrementally, extending the HTTP JSON API of Scrapyd.
GNU General Public License v3.0
89 stars 22 forks source link

Fix PATTERN_LOG_ENDING to be compatible with scrapy-fieldstats #17

Closed my8100 closed 5 years ago

my8100 commented 5 years ago

Add LATEST_SCRAPE_ITEM_PATTERN for extracting latest_scrape and latest_item.

pep8speaks commented 5 years ago

Hello @my8100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 81:42: E127 continuation line over-indented for visual indent Line 107:5: E116 unexpected indentation (comment) Line 108:9: E116 unexpected indentation (comment) Line 109:9: E116 unexpected indentation (comment) Line 110:5: E116 unexpected indentation (comment) Line 111:5: E116 unexpected indentation (comment) Line 112:5: E116 unexpected indentation (comment) Line 113:5: E116 unexpected indentation (comment) Line 114:5: E116 unexpected indentation (comment) Line 121:21: E116 unexpected indentation (comment)

Comment last updated at 2019-08-21 09:44:50 UTC
codecov[bot] commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.51%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   87.41%   87.92%   +0.51%     
==========================================
  Files           9        9              
  Lines         898      903       +5     
==========================================
+ Hits          785      794       +9     
+ Misses        113      109       -4
Impacted Files Coverage Δ
logparser/scrapylogparser.py 98.3% <100%> (+0.05%) :arrow_up:
logparser/logparser.py 95.6% <100%> (ø) :arrow_up:
logparser/common.py 100% <100%> (+4.21%) :arrow_up: