search

my8bird / node-leveldb

NodeJS bindings to levelDB - a fast and lightweight key/value database library
http://code.google.com/p/leveldb/
BSD 2-Clause "Simplified" License
63 stars 12 forks source link

npm install fails if coffee-script is already installed #16

Closed donpark closed 12 years ago

donpark commented 12 years ago

npm doesn't install coffee-script if it's already installed locally which leaves node-leveldb's own node_modules directory empty, causing following postinstall step to fail.

> leveldb@0.5.5 postinstall /Users/don/dev/test/node_modules/leveldb
> ./node_modules/coffee-script/bin/coffee -b -c -o lib/ src

sh: ./node_modules/coffee-script/bin/coffee: No such file or directory
donpark commented 12 years ago

Actually, I think preferred solution is to compile all .coffee files into .js files which would eliminate coffee-script dependency without forcing maintainers to abadon CoffeeScript.

One can automated this by adding a NPM prepublish script.

mikepb commented 12 years ago

Yes, I've done this on my branch so that coffee script doesn't need to be a dependency

mikepb commented 12 years ago

I mean I just checked in the compiled JS

mikepb commented 12 years ago

I don't know what's up with Travis-CI is failing...

donpark commented 12 years ago

great. I'll use your fork til official fix arrives. thx.

my8bird commented 12 years ago

travis is failing due to package not working on 0.7 yet

mikepb commented 12 years ago

@donpark the sync methods in my branch are going away, so steer clear! (unless there's a big need for them)

donpark commented 12 years ago

@mikepb message received. steering clear. :-p

my8bird commented 12 years ago

The api is now the head of master. Have at it and let us know if you issues with the new api.

donpark commented 12 years ago

awesome. tested master and can confirm this install issue as resolved. thx y'all.