search

my8bird / node-leveldb

NodeJS bindings to levelDB - a fast and lightweight key/value database library
http://code.google.com/p/leveldb/
BSD 2-Clause "Simplified" License
63 stars 12 forks source link

Fix iterator having global state #25

Closed mikepb closed 12 years ago

mikepb commented 12 years ago

I just realized that the iterator was using a global state instead of per-instance state. This update allows multiple iterators to work side-by-side.

my8bird commented 12 years ago

two things first why the package json change second instead of using bind on wrapSeek you could just use coffeescripts => notation when defining the method

mikepb commented 12 years ago
  1. It makes Travis-CI configure twice. I added make pkgclean to remove extra files on install from a package (e.g. not a git checkout). It's a bit hackish, but cleans up when needed and not when developing.
  2. It was late...
mikepb commented 12 years ago

Should probably do something about the random test fails too. I think it has to do with writing too many single records and not waiting long enough for leveldb to catch up. Could just reduce the number of test records.