search

my8bird / node-leveldb

NodeJS bindings to levelDB - a fast and lightweight key/value database library
http://code.google.com/p/leveldb/
BSD 2-Clause "Simplified" License
63 stars 12 forks source link

make node-leveldb ready for node 0.8.x #38

Closed pconstr closed 12 years ago

pconstr commented 12 years ago

includes commits from https://github.com/gflarity with thanks to https://github.com/AvianFlu tests pass: http://travis-ci.org/#!/pconstr/node-leveldb

gflarity commented 12 years ago

I've submitted a pull request to pconstr that fixes this. Afterwards it npm installs!

justmoon commented 12 years ago

The title is misleading, node-leveldb works fine for me on Node.js 0.8.3. I think the main advantage of node-gyp is Windows support?

Speaking of which, I'm maintaining a Windows branch of leveldb - using this with minimal changes it should be possible to make this module compile on Windows. I might have a go at it if I have some time and there is interest.

gflarity commented 12 years ago

Long story short, it does not work under OS X if you install the node.js binaries instead of compiling them yourself. Gyp magically makes these problems go away.

justmoon commented 12 years ago

Ok, I've done some testing. This pull request currently disables Snappy, which is a regression imho. So I've created a new pull here: #39.

Would be awesome if you guys could test that one and see if it works for you. I'll leave this one open until I get some feedback on the new one. (Technically, we could merge this one first. Then mine would be simply a pull to update the deps and reenable Snappy.)

gflarity commented 12 years ago

I agree removing Snappy is less than ideal and if you have a fix might as well just do it all together. Testing...

pconstr commented 12 years ago

good point, let's not drop Snappy

justmoon commented 12 years ago

People seem to be in agreement on keeping Snappy, closing in favor of #39.