Ensure httpClient gets the transport we create

myENA / consul-backinator

Command line Consul backup and restore utility supporting KVs, ACLs and Queries

Mozilla Public License 2.0

226 stars 22 forks source link

Ensure httpClient gets the transport we create #18

Closed KAllan357 closed 8 years ago

KAllan357 commented 8 years ago

This is why my tests that previously worked started failing: a new cleanhttp.DefaultTransport() was created and configured but never set to the httpClient

KAllan357 commented 8 years ago

Discussion here https://github.com/myENA/consul-backinator/pull/16; fixes a bug in 49feddf0f945afe7f7e87a07dbb2fe64a50a8ca1

cc @leprechau

aaronhurt commented 8 years ago

Great catch, that is indeed a miss. Thanks again.