search

myENA / consul-backinator

Command line Consul backup and restore utility supporting KVs, ACLs and Queries
Mozilla Public License 2.0
226 stars 22 forks source link

[Feature] Add support for IAM instance profile #23

Closed shamil closed 7 years ago

shamil commented 7 years ago

Hi,

Thanks for the tool. I've a feature request for S3 backup. Currently the S3 backup works by specifying AWS access/secret keys. Is it possible to add a feature that uses IAM instance profile where possible?

aaronhurt commented 7 years ago

@shamil Sorry for the really late reply. I'll need to dig into IAM a bit as I'm honestly not that familiar with how it works. I'll mark this as a feature request though and keep it open.

aaronhurt commented 7 years ago

@shamil I did some research and the library I'm currently using to provide S3 access doesn't appear to support IAM profiles. I selected the minio-go library for it's compact size and clean interface ... I'd be more than happy to review pull requests that used an alternative library though if this is an important feature for you.

aaronhurt commented 7 years ago

@shamil @baptiste-ls I pushed a new commit to master that uses the official AWS SDK instead of the minio client. This should enable all AWS/S3 features including IAM profiles. Would appreciate any testing or feedback you could offer.

aaronhurt commented 7 years ago

Closing and considering this feature request complete.