search

myFavShrimp / turf

Macro based compile-time SCSS transpilation, CSS minification, and class name uniquification toolchain inspired by CSS modules.
MIT License
50 stars 2 forks source link

Update lightningcss & implement changes which breaks build #10

Closed xeho91 closed 11 months ago

xeho91 commented 11 months ago

What was the issue?

In my project after running cargo update I noticed one of the dependencies had updates from the lightningcss. And build started to break.

After some investigation I noticed the pinned version of lightningcss, but it didn't stop from its dependencies from being updated. 😕

So, I've quickly updated the crate and implemented the change which breaks the build.

Annoying, but oh well.. at least I had a time to investigate and fix it quickly. Not sure what else can be done to prevent it from happening again. Any thoughts?

myFavShrimp commented 11 months ago

After some quick investigation my guess is that this originates from lightningcss's dependency on parcel_selectors, which itself depends on cssparser. The dependency was specified like this

cssparser = "0.29"

which is equivalent with 0.*.

They have fixed this already and this should not happen again (at least not because of cssparser).

Thank you for bringing this to my attention and offering a quick fix. Without your help it would have taken much longer to resolve the issue. I have merged your pr but pinned the lightningcss version again because it is necessary for Cargo to not choose a newer alpha version when building than the one specified :slightly_smiling_face: