search

myaaghubi / PHP-Frameworks-Bench

A library to make benchmarks from PHP frameworks.
GNU General Public License v2.0
109 stars 4 forks source link

Github action to test the setup and frameworks #16

Closed joanhey closed 1 year ago

joanhey commented 1 year ago

~Still work in progress.~ Ready to be merged.

~We need a better error handling in the check.sh~. Now it's failing, ~but don't return any error to mark the job as fail~. Some frameworks fail, with the initial setup. ~Perhaps we need to add more extensions~.

Later we can add a bench of ~10s, but first we need to create a config for the runner (only 2 cpu) and 50 treads and 500 connections is too many.

PD: to view in my repo https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5633201294/job/15261843959

Update: seems that only fail the permissions now Update: only fail Laravel now, and seems to permissions too https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5633660738/job/15262807159

All the checks pass now: https://github.com/joanhey/PHP-Frameworks-Bench/actions/runs/5636218622/job/15268055873

joanhey commented 1 year ago

The problem with Laravel is the artisan optimize than it's also deprecated.

image https://blog.runcloud.io/how-to-optimize-laravel/

image https://stackoverflow.com/questions/31895854/laravel-artisan-optimize-best-practices ....

joanhey commented 1 year ago

Ready to be merged !!!

myaaghubi commented 1 year ago

I checked it saw no problems so nice job :+1: