myaaghubi / PHP-Frameworks-Bench

A library to make benchmarks from PHP frameworks.
GNU General Public License v2.0
109 stars 4 forks source link

Ubiquity 2.5.2 #49

Closed joanhey closed 10 months ago

joanhey commented 10 months ago

In reality it's using this version, in the last run.

https://github.com/myaaghubi/PHP-Frameworks-Bench/actions/runs/7091046459/job/19299321908?pr=48#step:6:2152

The ubiquity-project always use any version ^2.3. https://github.com/phpMv/ubiquity-project/blob/master/composer.json#L13

myaaghubi commented 10 months ago

1.0.9 is the same dev-master / 2.4.x-dev

joanhey commented 10 months ago

Yes, it's the same, but install always the last ubiquity version. Now it is v2.5.2.

The only thing that look that work like 2.4.x-dev, is the branch alias. https://github.com/phpMv/ubiquity-project/blob/master/composer.json#L29-L30

And the releases in ubiquity-projectaren't correlative to the ubiquity versions. https://github.com/phpMv/ubiquity-project/releases

myaaghubi commented 10 months ago

Then make sure to update it with the correct version number, sometimes the version number of the skeleton does not match the version number of the core, so it is better to consider the version number of the repository that we're going with

joanhey commented 10 months ago

I think that you don't understand it.

The skeleton is updated to the last 1.0.9, that update automatically to any core v ^2.3. dev-master / 2.4.x-dev is only a branch alias, nothing else. Now it is using core v2.5.2. ^2.3 = ( >=2.3.0 <3.0.0)

The same happen with others frameworks. For example, Cakephp app skeleton is v5.0.1, but now install Cakephp core v5.0.3 and update automatically to "cakephp/cakephp": "^5.0.1". "^5.0.1" = ( >=5.0.1 <6.0.0 )

App skeleton version don't necessary correlate to core versions.

https://getcomposer.org/doc/articles/versions.md#caret-version-range-

joanhey commented 10 months ago

image

myaaghubi commented 10 months ago

Then make sure to update it with the correct version number, sometimes the version number of the skeleton does not match the version number of the core, so it is better to consider the version number of the repository that we're going with

App skeleton version don't necessary correlate to core versions.

Yep My point is if you go with a skeleton (create-project phpmv/ubiquity-project:1.0.* as your commit) then you would put the version number that belongs to that skeleton, or if you go with a core and make your own skeleton for it then you would put the version number that belongs to that core So in case, it is going to be :1.0 (consider other frameworks that we have in the list) however you may find it far from the core version number of the ubiquity like myself

joanhey commented 10 months ago

Do it like you want it !!

myaaghubi commented 10 months ago

Do it like you want it !!

Then, I prefer to keep it like before until the next update of ubiquity

joanhey commented 10 months ago

Perfect, but remember that now we are testing Ubiquity 25.2. And later any new version of ubiquity automatically.

myaaghubi commented 10 months ago

I already know that, we have the same thing for some of the other frameworks as well. Don't get upset due to rejection.