search

myaaghubi / PHP-Frameworks-Bench

A library to make benchmarks from PHP frameworks.
GNU General Public License v2.0
109 stars 4 forks source link

Add .gitignore #9

Closed joanhey closed 1 year ago

joanhey commented 1 year ago

Add all vendor/ dirs to .gitignore. Without when we setup the frameworks, exist +4k files to track in Git and it's unmanageable.

Still so, exist ~1k files to track, that complicate to manage the changes.

I think that it will be good to change the dirs structure, like /framework-xx/code/ (code, bench, ... you can choose). So we can add to .gitignore too /*/code/ and we will manage the changes only in the important files. At the same time is easier to delete (clean.sh) and we don't need the temporal dir temp in _benchmark to later copy the files.

myaaghubi commented 1 year ago

Check out the notes on you commit. Another idea to change the structure is to have a dir for pre-configured files (for frameworks) to completely separate them from what the composer gonna clone then we not gonna have the temp dir and stuff gonna goes easier for clean.sh as you mentioned and even may not mention the version number on related folders too! However at the moment I prefer the old structure :sleepy:

joanhey commented 1 year ago

image

After setup.sh, nobody can manage that.

joanhey commented 1 year ago

Also like anybody can update the frameworks via composer, it's unnecessary to have the minor versions in the framework dir.

It's enough with Codeigniter4 or Codeigniter3, ....