search

myalos / monodepth2nyu

4 stars 0 forks source link

Possible typo #2

Closed jwyndreee closed 1 year ago

jwyndreee commented 1 year ago

Dear author,

https://github.com/myalos/monodepth2nyu/blob/19bf44b1ec3d9fd58cb62e74bbc1718232136974/trainer.py#L99

I suspect the number 1 among the arguments should be changed to len(self.opt.scales), regarding compatibility.

Anyway, huge thanks for sharing your code!

I am trying to reproduce the results you have mentioned in https://github.com/SJTU-ViSYS/StructDepth/issues/9

myalos commented 1 year ago

You are right. I copied many code from StructDepth. StructDepth use only one scale to train. Thanks for the correction.