search

myang-git / iOS-Image-Crop-View

A view that allows user to select the cropping area in an image
383 stars 78 forks source link

Boundries of image #12

Closed ronnyk134 closed 9 years ago

ronnyk134 commented 9 years ago

When showing an image from the camera there is a part of the boundary not shown in the crop view. For normal pictures this is not noticeable since your area of interest is the center, however In some cases you are interested in items on the boundary and to me this is huge problem.

mnill commented 9 years ago

You have problem only with portrait photos?

mnill commented 9 years ago

There is problem with calculation size in app with\without status bar

ronnyk134 commented 9 years ago

image image image image

Yes it seem to be portrait only pictures. However this is a problem on both the x and y axis. On the y axis the image extends beyond and under the navigation bar at the top. So it's not only the size of the navigation bar but something more fundamental.

mnill commented 9 years ago

Can you try out my fork. until they will be merged?

ronnyk134 commented 9 years ago

Works like a charm. Thank you very much it has been extreml helpfull. Should I leave the issue open or would it be correct to merge it now ?

mnill commented 9 years ago

Yes, leave it opened