Refactor to code and class

myang-git / iOS-Image-Crop-View

A view that allows user to select the cropping area in an image

383 stars 78 forks source link

Refactor to code and class #8

Closed andreabusi closed 10 years ago

andreabusi commented 10 years ago

Hi, I think that the library need some refactor to the code. For example:

Better class name with Apple convention (ex. XYZImageCropView)
Split the library into multiple files (one for each interface defined in ImageCropView.h file)
Remove demo.mov file from the repository (we can link it in YouTube or similar)

I can help you with some of this points if you need :)

myang-git commented 10 years ago

Hi,

Thanks for the suggestion. I think all three points make sense. The reason why I put all classes in the same .h and .m files was originally these classes are quite small, therefore having them in the same location makes it easier to navigate. Also managing one file, rather than three files, to me, was simpler at that moment :)