search

myano / jenni

jenni was a python IRC bot. Project is closed. Try Sopel instead, https://sopel.chat/
https://sopel.chat/
Other
235 stars 101 forks source link

Make rss/weather timers changable. #71

Closed ghost closed 11 years ago

ghost commented 12 years ago

Currently jenni has some timers that are set inside the modules themselves.

modules/rss.py = 600 seconds modules/nws.py = 60 seconds

Make these a global setting? Maybe store them inside the ~/.jenni/default.py config?

possible make a new command to change them?

jenni: set rss time 1200 (set the rss to 1200 second intervals).

Possibly apply this idea to other modules that have timers?

myano commented 11 years ago

I don't believe this is really necessary,especially for the nws.py module. If the time is dropped too low NOAA may start blocking too frequent requests. Also same idea would be bad for the rss.py as well.

myano commented 11 years ago

I do have a plan to move the .rate limit functions into default.py and have them work with developers of modules, however, for modules where there is no .rate I don't see a point in exposing these time functions to the user of the bot as that could cause problems between people who create the modules and those who interface with it. (IE: some sites have problems if they are pinged too often).