search

mybatis / ibatis-spring

Ibatis integration code copied from Spring ORM 3.2.x branch
Apache License 2.0
28 stars 16 forks source link

Fully bring in springs code and update any spring logic as needed #61

Open hazendaz opened 1 year ago

hazendaz commented 1 year ago

Usage of ibatis just doesn't want to fully go away. I'm well aware of many usages up through jdk 17 using spring 5 latest. This logic was originally pulling the source but then switched to doing so without copying springs code in case they made updates. Well, its been many years, there won't be updates, so pom needs reworked to slurp in source more closely to how it works now with ability to do that one of if ever needed (unlikely) and then code needs managed up to spring 5 (internals). That will further allow feasibility of going to spring 6 in a subsequent release.

agharta commented 11 months ago

Hi, I apologize for the trouble. Is there any news about that? Unfortunately, it is not easy for us to migrate more than 8000 queries and the solution must necessarily be gradual. We use Spring only to handle transactions and connection pooling. If ibatis-spring could be compatible with Spring 5.x it would allow us to have a gradual and painless migration. Thank you for your precious support, Agharta

hazendaz commented 11 months ago

I think your concern is quite different. The library here has long allowed the code to run with spring 4 and 5 as that is its purpose and it works well for that. You don't need to update anything.

This issue has to do with how we make this compatible with spring 6 at some point as it is likely to break given we use underlying spring from spring 3 which really is just direct code so it was decoupled from spring itself.

But again you are able to use now without issue with spring 5.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: agharta @.> Sent: Monday, October 9, 2023 3:14:47 AM To: mybatis/ibatis-spring @.> Cc: Jeremy Landis @.>; Assign @.> Subject: Re: [mybatis/ibatis-spring] Fully bring in springs code and upgraded to spring 5 (Issue #61)

Hi, I apologize for the trouble. Is there any news about that? Unfortunately, it is not easy for us to migrate more than 8000 queries and the solution must necessarily be gradual. We use Spring only to handle transactions and connection pooling. If ibatis-spring could be compatible with Spring 5.x it would allow us to have a gradual and painless migration. Thank you for your precious support, Agharta

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/ibatis-spring/issues/61#issuecomment-1752457548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI6T3VT4YI7L2RN5SRLX6OP6PAVCNFSM6AAAAAAS3DKGD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGQ2TONJUHA. You are receiving this because you were assigned.Message ID: @.***>

agharta commented 11 months ago

Oh, great! Reading the Readme.md there is no mention of Spring 5.x but only of 4.x. I didn't realize the code was already compatible with Spring 5.x! I misunderstood, it's better that way. You saved me!! Thanks again and have a nice day! Agharta

hazendaz commented 11 months ago

I'll update the readme when I have a chance to make that more clear and will update this ticket to clarify what the intention was. Thanks for pointing that out.