search

mybatis / mybatipse

Eclipse plugin adding support for MyBatis SQL Mapper Framework.
Eclipse Public License 1.0
332 stars 91 forks source link

It would be better to distinguish between the statementIds that have been used and those that have not been used #87

Closed shuchang01 closed 6 years ago

shuchang01 commented 6 years ago

qq 20180726110546

harawata commented 6 years ago

Thanks for the idea, @shuchang01 !

I would just exclude IDs that are already declared in the XML mapper from the list. Let me know if there is any problem with this spec.

harawata commented 6 years ago

Actually, there can be multiple statements with the same 'id' and a different 'databaseId'. 😑

I'll use the translucent icon for IDs that are already used. In the picture below, 'select1' and 'select2' are already used.

shuchang01 commented 6 years ago

Thanks for your timely reply. It is better to use the translucent icon.

harawata commented 6 years ago

Just released 1.2.0 with this enhancement. Let me know if there is any problem. Thank you!

shuchang01 commented 6 years ago

I've updated to version 1.2.0, and the enhancements are working well for now.

shuchang01 commented 6 years ago

Thank you very much.