fix: Fix flaky test (testBlockingCache) on master/pr's

mybatis / mybatis-3

MyBatis SQL mapper framework for Java

http://mybatis.github.io/mybatis-3/

Apache License 2.0

19.72k stars 12.82k forks source link

fix: Fix flaky test (testBlockingCache) on master/pr's #3121

Closed epochcoder closed 6 months ago

epochcoder commented 6 months ago

This test has been failing sporadically on some CI runners.

Use more modern approach to shut down thread pool, awaitTermination (prevent infinite loop in case of failure)
Use assertJ so we can get the reason it failed if it does
Change to greaterThanOrEqualTo as this test is successful if the calls blocked on each other and we know that with (500ms * 2)

coveralls commented 6 months ago

coverage: 87.167%. remained the same when pulling efdb78aa6bdf23d5325a9118630e441b15e9d43d on epochcoder:fix/blocking-test-flaky into e346c0736c1cf941e27b8acb42ac4bda15302677 on mybatis:master.

harawata commented 6 months ago

Thank you, @epochcoder !

I was aware of the flakiness, but didn't pay much attention to it. Let's see how this works.