search

mybatis / parent

The MyBatis parent POM which has to be inherited by all MyBatis modules
Apache License 2.0
177 stars 476 forks source link

Maven Site 4 will break code highlight of Markdown source #600

Open awxiaoxian2020 opened 10 months ago

awxiaoxian2020 commented 10 months ago

repro repo https://github.com/awxiaoxian2020/code-render-bug master branch is Maven Site 3 with Fluido skin 1 v4 branch is Maven Site 4 with Fluido skin 2.

Open their respective target/site/test.html files in local to see the rendered result.

hazendaz commented 10 months ago

Not sure I follow. Can you provide screen shots?

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Xavi Lee @.> Sent: Friday, February 2, 2024 7:33:12 AM To: mybatis/parent @.> Cc: Subscribed @.***> Subject: [mybatis/parent] Maven Site 4 with Fluido skin 2 will break code highlight of Markdown source (Issue #600)

repro repo https://github.com/awxiaoxian2020/code-render-bug master branch is Maven Site 3 with Fluido skin 1 v4 branch is Maven Site 4 with Fluido skin 2.

Open their respective target/site/test.html files to see the rendered result.

It's confusing me that https://github.com/mybatis/spring-boot-starter/releases/tag/mybatis-spring-boot-3.0.3 uses mybatis-parent v40 using mave site 4 but the site skin is Fluido skin 1...

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/parent/issues/600, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI7DKCAN7PL64GIRPB3YRTMIRAVCNFSM6AAAAABCWTMMPWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTIOBSHEZTIOI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

awxiaoxian2020 commented 10 months ago

maven-site-3 maven-site-4

awxiaoxian2020 commented 10 months ago

You can compare MyBatis Site English Content with MyBatis-Spring-Boot-Starter 3.0.2 Site Content, the latter use mybatis-parent 37.

awxiaoxian2020 commented 10 months ago

I also post a issue at https://issues.apache.org/jira/browse/MSITE-1002

hazendaz commented 10 months ago

Possibly related to https://issues.apache.org/jira/browse/DOXIA-571. Was broken in earlier releases then fixed, possibly history repeating itself.

hazendaz commented 10 months ago

See https://shred.zone/cilla/page/431/fluido-skin-and-markdown-syntax-highlighting.html

Using that, I added this site.xml

<site>
    <skin>
        <groupId>org.apache.maven.skins</groupId>
        <artifactId>maven-fluido-skin</artifactId>
        <version>2.0.0-M8</version>
    </skin>
    <body>
        <head>
          <!-- Workaround for https://issues.apache.org/jira/browse/DOXIA-571 -->
          <![CDATA[<script type="text/javascript">
            $(document).ready(function () {
              $(".language-java").addClass("prettyprint");
              prettyPrint();
            });
          </script>]]>
        </head>

    </body>
</site>

Issue is fixed then. Thanks for opening ticket with maven.

awxiaoxian2020 commented 10 months ago

So should we add a workaround like this in mybatis-parent now?

hazendaz commented 10 months ago

It would be easier to get a proper fix. The work around would require more fixes. I simply fixed it for java. I'll continue looking at this but hope maven team knows the issue. Either way it would be weeks to patch I'm sure.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Xavi Lee @.> Sent: Saturday, February 3, 2024 9:02:29 PM To: mybatis/parent @.> Cc: Jeremy Landis @.>; Comment @.> Subject: Re: [mybatis/parent] Maven Site 4 will break code highlight of Markdown source (Issue #600)

So should we add this workaround in mybatis-parent now?

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/parent/issues/600#issuecomment-1925550748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODIY2GSXFKPOF576KVMDYR3T3LAVCNFSM6AAAAABCWTMMPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGU2TANZUHA. You are receiving this because you commented.Message ID: @.***>

awxiaoxian2020 commented 6 months ago

Maven team have fixed it and could we publish the site to fix this issue?

hazendaz commented 6 months ago

Did they fix it in M14 or M15? M14 was already released here. For M15, will be likely end of the month.

awxiaoxian2020 commented 6 months ago

I mean, for example we can release mybatis-3 to apply what updated.

hazendaz commented 6 months ago

All our downstream projects just need our site branch sync'd to run the site github action. I'll take care of that as I'm updating maven wrapper over this week.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Xavi Lee @.> Sent: Tuesday, June 4, 2024 6:31:39 AM To: mybatis/parent @.> Cc: Jeremy Landis @.>; Comment @.> Subject: Re: [mybatis/parent] Maven Site 4 will break code highlight of Markdown source (Issue #600)

I mean, for example we can release mybatis-3 to apply what updated.

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/parent/issues/600#issuecomment-2147187381, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI2XW4QVVHXBVE44DRLZFWJQXAVCNFSM6AAAAABCWTMMPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGE4DOMZYGE. You are receiving this because you commented.Message ID: @.***>

awxiaoxian2020 commented 5 months ago

Any update on site branch?

hazendaz commented 5 months ago

I pushed the site, please check tomorrow or after to see if it updated as expected. I checked just now but its still showing from April and I think there is some delay in it showing up. Let me know what you see. Thanks!

awxiaoxian2020 commented 5 months ago

It didn't update…

hazendaz commented 5 months ago

looking into the issue, no ETA. For whatever reason the site did not upload like expected. I'm checking to see if its because its not a final release. I don't want to release just to get site working but if that is the case, will take some time to do some code cleanups throughout so that the release is more than just fixing the site.

hazendaz commented 4 months ago

Maven didn't actually fix the issue at all. I tried your code again and it still needs the patch I noted to even work. So you may want to ping them again since it doesn't seem they fixed anything. They got rid of a 'div' around the block but prettyprint is no where to be found.

awxiaoxian2020 commented 1 month ago

https://github.com/apache/maven-site-plugin/pull/210 has upgraded the fluido skin version which is fixing this issue just now. But I don't know when the team will release maven-site-plugin-4.0.0-M17...

hazendaz commented 1 month ago

Maven went backwards.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Xavi Lee @.> Sent: Friday, October 18, 2024 10:53:48 PM To: mybatis/parent @.> Cc: Jeremy Landis @.>; Assign @.> Subject: Re: [mybatis/parent] Maven Site 4 will break code highlight of Markdown source (Issue #600)

apache/maven-site-plugin#210https://github.com/apache/maven-site-plugin/pull/210 has upgraded the fluido skin version which is fixing this issue just now. But I don't know when the team will release maven-site-plugin-4.0.0-M17...

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/parent/issues/600#issuecomment-2423526436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI74I3FYUE53B244M4TZ4HCTZAVCNFSM6AAAAABCWTMMPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGUZDMNBTGY. You are receiving this because you were assigned.Message ID: @.***>

hazendaz commented 1 month ago

Sorry hit send to fast. It's 3.x.20 version now. All parts but fluido are all 4 x versions on GA. I don't know that I updated the mybatis parent yet. If you have some time send a PR if I had not yet and I'll get it released shortly after.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jeremy Landis @.> Sent: Saturday, October 19, 2024 9:38:50 AM To: mybatis/parent @.>; mybatis/parent @.> Cc: Assign @.> Subject: Re: [mybatis/parent] Maven Site 4 will break code highlight of Markdown source (Issue #600)

Maven went backwards.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Xavi Lee @.> Sent: Friday, October 18, 2024 10:53:48 PM To: mybatis/parent @.> Cc: Jeremy Landis @.>; Assign @.> Subject: Re: [mybatis/parent] Maven Site 4 will break code highlight of Markdown source (Issue #600)

apache/maven-site-plugin#210https://github.com/apache/maven-site-plugin/pull/210 has upgraded the fluido skin version which is fixing this issue just now. But I don't know when the team will release maven-site-plugin-4.0.0-M17...

— Reply to this email directly, view it on GitHubhttps://github.com/mybatis/parent/issues/600#issuecomment-2423526436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI74I3FYUE53B244M4TZ4HCTZAVCNFSM6AAAAABCWTMMPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGUZDMNBTGY. You are receiving this because you were assigned.Message ID: @.***>

awxiaoxian2020 commented 1 month ago

Sorry, I forgot fluido is independent in this project. maven should fixed it in 2.0.0-M10. So maybe at least we can just release...

awxiaoxian2020 commented 1 month ago

I have previewed at local machine. You just need to release the parent-46, we can fix this issue.

awxiaoxian2020 commented 23 hours ago

Hi, @hazendaz When do you release parent-46? 👀

hazendaz commented 2 hours ago

This has been released at parent 46. It should start cycling around in a few hours. I'll be away though so maybe @harawata might see and pick those up. If I recall, you are concerned about mybatis core itself. I'm not 100% convenience maven fixed anything. But there were nearly 160 commits or so, so lets give it a shot and see ;)

hazendaz commented 2 hours ago

will keep this open until we know for sure.