search

mybatis / spring-boot-starter

MyBatis integration with Spring Boot
Apache License 2.0
4.13k stars 1.79k forks source link

Coveralls github actions fails because sample packages conflict on package names #556

Open hazendaz opened 3 years ago

hazendaz commented 3 years ago

All the samples use the same package space. This is generally not a good idea. In order to fix coveralls so it works during github actions, all the samples need to be put into their own name spaces.

This can be seen by simply running this dummy run locally to emulate the issue. Then go into any sample and the issue goes away.

mvn test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=x -DserviceName=github

Note the above run is not intended to work, just to show the issue then show that isolated samples do not have the problem. If you look at the file in error, it happens in all samples and the lines different in each. Most tools would already complain of this approach type.

Solution would be to add in the type of the package. So sample.mybatis for example should become sample.freemarker.mybatis if in the freemarker package.

snagapuriosc commented 3 years ago

@hazendaz I am trying to work on this as good first issue , Can you please validate if changes all sample packages from sample.mybatis to sample.freemarker or sample.groovy etc ... will fix the package issue ? Also I changed test package accordingly sample.annotation.test.mybatis.

hazendaz commented 3 years ago

Hi @snagapuriosc, I had completely lost track of this. That would do it though. Basic issue is the overlaping naming that it has issues with. By splitting those out the names won't overlap any longer. I forget all the exact details of this issue now but nothing was ever done and I think the instructions I left were enough to address. I probably intended that I did that at some point and was a place holder to not forget but have at it as I see you started playing around with that already.

snagapuriosc commented 3 years ago

@harryharanb @Rdx-delhi Hi Hari, Vatsala.

As discussed to get started on open source contribution I worked on open issue,Can you guys please review and advise on below commit id before I create a PR. https://github.com/snagapuriosc/spring-boot-starter/commit/4ab48cc514aff2801fda8fc237b4d2b530b14ed6

Thanks Sunil