search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
32 stars 33 forks source link

Merge System doesn't work with MyBB 1.8.4 #158

Closed ATofighi closed 9 years ago

ATofighi commented 9 years ago 
Fatal error: Interface 'DB_Base' not found in D:\xampp\htdocs\mybbmerge\inc\db_mysqli.php on line 12
JN-Jones commented 9 years ago

Ah, @euantorano changes. We need to fix the 1.8.3 package, the version here on GitHub is already modified but isn't release ready due some incomplete fixes.

euantorano commented 9 years ago

Yep, my fault. Sorry! :wink:

ATofighi commented 9 years ago

:) If we don't want to change merge-system we can change the db_***.php files

JN-Jones commented 9 years ago

They're included in the mybb package so that isn't an option. We simply need to release merge system 1.8.4 based on the 1.8.3 package, fixing this issue and changing the version info.

ATofighi commented 9 years ago

@JN-Jones we can only add 

require_once MYBB_ROOT."inc/db_base.php";

to inc/db_mysql.php and inc/db_mysqli.php and don't release new merge-system! :)

JN-Jones commented 9 years ago

Thats something @euantorano needs to decide as he was the one writing the base class.

euantorano commented 9 years ago

I'd say it's better to edit the merge system. IMO the class files should contain only the classes, nothing else. This is a standard convention in PHP.

Sama34 commented 9 years ago

Even if the change is minimal a new version should be released.

JN-Jones commented 9 years ago

There's no discussion about whether this should be fixed, only about how and where?

Sama34 commented 9 years ago

Per @ATofighi comments I understand he suggest to change the package only t oa minimum without marking a new release.

His fix looks good to me anyways. I seems to be backwards compatible.