search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 33 forks source link

Forums module uses undefined variable #162

Closed JN-Jones closed 9 years ago

JN-Jones commented 9 years ago

The import function uses an undefined variable:

            // Update parent list.
            if($insert_forum['type'] == 'c')
            {
                $db->update_query("forums", array('parentlist' => $fid), "import_fid = '{$forum['fid']}'");
            }

$insert_forum is nowhere defined so the if will always be false. As I wasn't able to find any issues so far and the parentlist is updated in the cleanup function anyways I'll simply remove the if.