Cleanup code - Githubissues

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.

Other

34 stars 33 forks source link

Cleanup code #167

Closed JN-Jones closed 9 years ago

JN-Jones commented 9 years ago

As mentioned on slack: The code needs to be cleaned up. There are quite a lot of places where we define a variable but never use it or use a variable that's never used. Same for functions. Also sometimes functions are added to the wrong class. A lot of php doc blocks are wrong. Developing the merge system with an IDE doesn't make fun at the moment as you get too many errors.

I heard @euantorano volunteered to fix this?

JN-Jones commented 9 years ago

TODO:

[ ] Make some classes abstract
[x] Remove closing php tag
[x] Class output globalizes $output 2-times, instead of using $this
[x] Instead of doing if(method_exists) -> callMethod the method should be added as empty method to the parent class
[x] Update file headers, some still say MyBB 1.6
[ ] Testing

euantorano commented 9 years ago

Yes, I'll fix the doc blocks, etc. I'll work on it over this month/next month.

JN-Jones commented 9 years ago

You're too late to the party ;)

euantorano commented 9 years ago

:(

JN-Jones commented 9 years ago

Be happy - it took me more than 4 hours ;)

euantorano commented 9 years ago

Ouch. Rather you than me!

JN-Jones commented 9 years ago

Ok, hopefully fixed most things now. I'll leave this open for now as I haven't tested it yet.

JN-Jones commented 9 years ago

This is finished now