mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 33 forks source link

Fix 'unknown column m.id' error when migrating moderators for IPB 3 #181

Closed leith closed 7 years ago

leith commented 9 years ago

Currently moderators migration results in:

MyBB has experienced an internal SQL error and cannot continue.

SQL Error: 1054 - Unknown column 'm.id' in 'field list' (or mgroup) Query: SELECT mr.*, IF(mr.is_group = 1, m.id, mr.member_id) as member_id FROM moderators mr LEFT JOIN members m ON(mr.group_id = m.mgroup) LIMIT 0, 1000

Please contact the MyBB Group for technical support.

OzWookiee commented 8 years ago

I made these same changes and it seems to work but stalled after the first batch of 20.

JN-Jones commented 8 years ago

There are quite some issues with moderators in nearly all supported softwares: #180

FiretronP75 commented 8 years ago

I've confirmed this fix works, on 2 different installs. It should probably be merged in.

JN-Jones commented 7 years ago

Hi, as we decided to stop development I'll close this PR. However we'll keep this kind of issue in mind when we develop the new merge system for MyBB 2.0. I hope you understand that decision.

leith commented 7 years ago

@JN-Jones I can understand focusing on new development, although leaving a PR open and unattended for more than a year is pretty bad form. Hopefully you will be more attentive to your community contributions in your new product.

Good luck with the push towards 2.0!

JN-Jones commented 7 years ago

That should change with 2.0 too as more developers will work on the merge system then. This one was developed by one person only who left the team a few years ago and I was the only one afterwards who knew (at least a bit) how the system worked. And for the last couple of months I was pretty busy so nothing was done that time (one of the reasons we decided to officially put an end to this).