search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
32 stars 33 forks source link

Replaced /e modifier with preg_replace_callback #191

Closed debuggest3 closed 7 years ago

debuggest3 commented 8 years ago

Support for the /e modifier has been removed in PHP7.

JoshHarmon commented 8 years ago

It's also been changed in the core, so it would be very logical to make the change in the merge system.

Stefan-MyBB commented 8 years ago

Since the Merge System is supposed to support PHP 5.2 closures can't be used.

JN-Jones commented 8 years ago

@dgrp Can you fix the closures?

debuggest3 commented 8 years ago

Why do you need to support PHP 5.2? It's been end of life for 5 years already (http://php.net/eol.php).

Stefan-MyBB commented 8 years ago

@dgrp Because we claim MyBB 1.8 is compatible with it: http://docs.mybb.com/1.8/install/requirements/ It's certainly not a good idea to break compatibility for such a minor thing.

debuggest3 commented 8 years ago

I get that, but it doesn't answer my question. At some point the choice was made to support that version of PHP. Only thing I can think of is that a large part of MyBB's userbase is still running PHP 5.2... But I really hope that's not the case.

It's no problem for me changing the pull request, but I just find it sad to see that such a great piece of software is getting potentially held back by not embracing new technologies but instead chooses to stay stuck in the past and keeps supporting old software.

Stefan-MyBB commented 8 years ago

While MyBB 2.0 will require PHP 5.5 MyBB 1.8 is supposed to provide compatibility most PHP versions still in use. Unfortunately some hosts never update PHP...

JN-Jones commented 8 years ago

Yeah, there are still a lot of hosts on 5.2. I've got quite a lot of requests after I've bumped the requirement for my plugins to 5.3. So it was decided that 1.8 still supports 5.2 however the requirement will be bumped for 2.0.