search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 33 forks source link

Allow boards to run their modules if directly derived from Converter_Module class #229

Closed yuliu closed 4 years ago

yuliu commented 4 years ago

If the Merge System can allow this, we can easily write any module even there's no base module class supported naively, by deriving directly from Converter_Module abstract class.

I've done so in my Discuz X2.5 converter. A PR is on its way.

By doing so, old or existing modules that are based on the internal module classes are not affected. Nothing should be worried about except that there's no statistic data for those executed customized modules.

Demo result:

Modules
-------
The following modules from this converter were completed:
Database Configuration
Settings
Users
Extended User Profile Fields
Extended User Profile Information
Announcements
Thread Prefixes
Forums
Forum Permissions
Moderators
Threads
Polls
Poll Votes
Posts
Attachments

Import Statistics
-----------------
The MyBB import system imported the following from your copy of Discuz! X2.5:
Users:             6,176
Forums:            46
Forum Permissions: 46
Moderators:        46
Threads:           13,252
Posts:             204,805
Attachments:       6,747
Polls:             297
Poll Votes:        816
Settings:          22
yuliu commented 4 years ago

Second thoughts on this, it's better to create new modules for the Merge System rather than allowing "tweaks" like this unwisely, since developers themselves are able to do it. Will close this issue and the PR.