search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 33 forks source link

Add Discuz! X2.5 and Discuz! UCenter 1.6.0 converters #230

Closed yuliu closed 4 years ago

yuliu commented 4 years ago

Add support for converting Discuz! X2.5, dzx25. Add support for converting Discuz! UCenter 1.6.0, dzucenter. UCenter 1.6.0 is used across Discuz! version from X2.5 to X3.x.

Although X2.5 is an older version (latest release is in 2017), support for converting X3.x are planned. Placeholders in the loginconvert.php plugin are just fine.

Resolve #229, without which some modules must be disabled in the dzx25 converter. It's compatible with existing modules. Also try to fix #226, the UTF-8 problem. See the encode_to_utf8() function in the board's class.

By the day, I implemented a lot of switches to turn some features on/off, read the README.me files in these two converters for details. The last but not the least, the dzx25 converter has a built-in generator for URLs redirecting, which is disabled by default. Use it at your own risk.

yuliu commented 4 years ago

Sorry for my inexperienced using of git. I've some questions here:

  1. Should I just copy my code into a new branch without checkout to avoid so many in-development commits, which looks rather odd, but just one or a very few commits?
  2. The redirects generator is not a original feature that comes with the Merge System. It works as trying to generate some PHP files allowing redirects, let's say a URL like http(s)://PATH_TO_DISCUZ/forum.php?mod=forumdisplay&fid=333 to http(s)://PATH_TO_MYBB/forumdisplay.php?fid=333 with a HTTP 301 header. Should I remove it when I pull a request to mybb's merge-system repo?
  3. I've made a lot of switches for a user to control the converting, some of which are trying to solve Discuz! problems, is this acceptable?

If anything breaks MyBB's rules, please close this PR, and I'll try to push a more standard one. 😳

ShikiSuen commented 4 years ago

I wonder why Discuz converters are not included in the official release.

yuliu commented 4 years ago

@ShikiSuen probably Discuz! that is favored by east-Asian forum ownsers isn't popular across the whole wold.

ShikiSuen commented 4 years ago

@ShikiSuen probably Discuz! that is favored by east-Asian forum ownsers isn't popular across the whole wold.

That's not the reason. Discuz is "dying" from new-tech-lovers' perspective, and is mainly for people who have extremely little ability to maintain web servers by themselves. There are lots of users who want to try new forums.

By the way, thank you for the Discuz x2 converter you wrote.