Resolve #232, #211 chunked negative integer column length check during an insert

[yuliu]

Resolve #232, the prepare_insert_array () function now should recognize a negative integer input for column length check. Then fix #211, the threads/posts visibility can be set correctly.

Already converted boards should check their database with (replace mybb_ with an actual table prefix):

SELECT COUNT(*) FROM mybb_threads WHERE visible NOT IN (-1, 0, 1);
SELECT COUNT(*) FROM mybb_posts WHERE visible NOT IN (-1, 0, 1);

to see if any thread/post's visibility is incorrect. Update the visible fields for them, accordingly, -1 for deleted or -2 for drafted.

[yuliu]

The only commit in this PR was committed in #236 that was on top of this commit. @euantorano, what should I do to this PR and #236?

[euantorano]

So this PR is effectively already merged by the other one being merged? If som this can just be closed I’d say.

On Fri, 14 Feb 2020, at 05:56, yuliu wrote:

The only commit in this PR was committed in #236 https://github.com/mybb/merge-system/pull/236 that was on top of this commit. @euantorano https://github.com/euantorano, what should I do to this PR and #236 https://github.com/mybb/merge-system/pull/236?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mybb/merge-system/pull/233?email_source=notifications&email_token=AAFW24PLCBAWTARJRXVQEIDRCYXBHA5CNFSM4ISCXNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXVL4A#issuecomment-586110448, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFW24LPG6YDY33P3D24QYTRCYXBHANCNFSM4ISCXNLA.

[yuliu]

Seems so.

What will the code become if the PR is being merged? Anyway I think it'd better for MyBB members to operate on this PR and its linked issues. 🤣

[euantorano]

Ok, I'll close this for now. I need to go through some of the other issues and PRs this weekend.