Latest Vanilla Forum importing issues (Forum has no parents, threads or posts)

luisalvarado commented 3 years ago

Found several issues when importing from Vanilla to MyBB 1.8.24 (Using Merger 1.8.23)

Which is related to a Field 'directory_password' doesn't have a default value. If set to null by default then I get another column 'forum_password' which also has the same non default value issue.

When importing the Avatars (uploads folder is already 777)

This happens because normally the merger folder is in the root, so the default correct value should be ../uploads

After vanilla forum is imported I end up with an empty forum and the relationships between the forum parents, child and the categories that group them was empty. So it looked like this:

And there are too many to group, not to mention the posts / threads do not show because of this I am guessing.

luisalvarado commented 3 years ago

For the moment, I can understand the amount of work that is invested here, but would someone have a query or group of queries that could fix the relationship between categories, posts and threads?

euantorano commented 3 years ago

I've been looking into this, and continue to do so.

There is no field called directory_password in the MyBB core, or referenced in the merge system. I assume you are merging into a clean new MyBB install, right? I also can't find a reference to directory_password in the open source Vanilla code.
The error message:

Invalid user specified for "get_upload_avatar_name"

Is caused by the merge system not being able to find a matching user ID for one of the avatars being imported. I'm still trying to work out the exact cause for this, hoping to get that finished tomorrow or Saturday.
The merge system is supposed to create a category called Vanilla imported forums, under which all forums from Vanilla are supposed to be nested since Vanilla has no concept of categories. I'm not yet sure why this isn't working. There are some other bits of logic ran relating to nesting too which I need to double check for soundness.

I'm hoping I'll get a chance to open a PR tomorrow night after work. Issue 3 is my current priority, so the initial PR will be focussed on that.

luisalvarado commented 3 years ago

Hi @euantorano thank you friend. Yes for some reason when doing the merge with a clean mybb and the SQL files I sent over it happens. But what I did was set a default value for those.

For everything else THANK YOUU. Because you are helping me and 5 others that want to leave vanilla because of their shady nature.

luisalvarado commented 3 years ago

Hi @euantorano you were right. I just did a clean mybb (Deleted everything and started from scratch on the server). There was no directory_password. Not just this one but another column that had the same issue.

euantorano commented 3 years ago

Ok, so hopefully that’s issue 1 sorted 😀

On Fri, 11 Dec 2020, at 13:39, Luis Alvarado wrote:

Hi @euantorano https://github.com/euantorano you were right. I just did a clean mybb (Deleted everything and started from scratch on the server). There was no directory_password.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mybb/merge-system/issues/264#issuecomment-743197446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFW24LGYEI7CRM4OQJXYL3SUIOH7ANCNFSM4UMPVNOQ.

luisalvarado commented 3 years ago

Hi team MyBB, is there any updates or how can I help?

euantorano commented 3 years ago

I’m finishing work for the Christmas break tomorrow, and will have more free time from then. Expect a PR after that, as I’ve finished my larger PR for the MyBB core.

On Thu, 17 Dec 2020, at 18:26, Luis Alvarado wrote:

Hi team MyBB, is there any updates or how can I help?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mybb/merge-system/issues/264#issuecomment-747616366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFW24JOZCMYTP3J2UGENDDSVJEOLANCNFSM4UMPVNOQ.

luisalvarado commented 3 years ago

I’m finishing work for the Christmas break tomorrow, and will have more free time from then. Expect a PR after that, as I’ve finished my larger PR for the MyBB core. … On Thu, 17 Dec 2020, at 18:26, Luis Alvarado wrote: Hi team MyBB, is there any updates or how can I help? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#264 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFW24JOZCMYTP3J2UGENDDSVJEOLANCNFSM4UMPVNOQ.

Euan YOU ARE AN ANGEL. A LIFE SAVER!

luisalvarado commented 3 years ago

Happy new year @euantorano got any good news. Can I help you in any way or contribute some idea/information?

euantorano commented 3 years ago

Happy new year @euantorano got any good news. Can I help you in any way or contribute some idea/information?

Good news: I can replicate the problem. Bad news: I've not worked out a solution yet.

I'm hoping to get it running through an import properly in the next few days. The thing that slows me down is the cycle of installing a new board each time to test, but there's not a lot we can do about that.

luisalvarado commented 3 years ago

For me that is great news. If you are able to replicate, then from there, debugging, checking what missing ; is affecting this and how many cups of coffee are needed will be easy. Thank you friend. For the testing, I can give access to instances in digital ocean if that helps.

luisalvarado commented 3 years ago

Hi @euantorano how are the fixes going my friend. Can I test something to give you feedback?

euantorano commented 3 years ago

Hi @euantorano how are the fixes going my friend. Can I test something to give you feedback?

Hey, I've managed to get the forums and threads imported, but there are still some issues to resolve, like clicking on a thread/forum results in an Invalid forum error. I'm looking into that right now.

The forum index page does show all the forums and there latest threads though, so it's quite a strange issue.

euantorano commented 3 years ago

Ah, I think I've just found the cause for this. After the import the forum cache contains entries like the following:

 [100] => Array
        (
            [fid] => 100
            [name] => Your Trial Has Expired - Click Here for Info
            [description] => 
            [linkto] => 
            [type] => f
            [pid] => 3
            [parentlist] => 
            [disporder] => 2
            [active] => 1
            [open] => 1
            [allowhtml] => 0
            [allowmycode] => 1
            [allowsmilies] => 1
            [allowimgcode] => 1
            [allowvideocode] => 1
            [allowpicons] => 1
            [allowtratings] => 1
            [usepostcounts] => 1
            [usethreadcounts] => 1
            [requireprefix] => 0
            [password] => 
            [showinjump] => 1
            [style] => 0
            [overridestyle] => 0
            [rulestype] => 0
            [rulestitle] => 
            [rules] => 
            [defaultdatecut] => 0
            [defaultsortby] => 
            [defaultsortorder] => 
        )

Note the empty parentlist- this is an empty string. In the MyBB core's get_forum function, we explode this string on , which results in a single empty string which means we return false.

Rebuilding the forums cache seems to resolve this issue.

I'm now just combing through some threads and forums.

luisalvarado commented 3 years ago

Thank you buddy. That had to be a lot of investigative work. I will wait for this to be merge so I can try it with a new import. Pretty sure you killed all the bugs for vanilla.

luisalvarado commented 3 years ago

After doing a clean database and using the latest merge version this is the only issue I am having. The whole process now finishes correctly mind you.

But when you get to view the forum (after cleaning the cache in the mybb settings in Tools & Maintenance -> Cache Manager I still get this error. It shows on the front as "Vanilla imported forums" but when clicked in says:

"Sorry, but the forum you are currently viewing does not contain any child forums."

euantorano commented 3 years ago

After doing a clean database and using the latest merge version this is the only issue I am having. The whole process now finishes correctly mind you.

But when you get to view the forum (after cleaning the cache in the mybb settings in Tools & Maintenance -> Cache Manager I still get this error. It shows on the front as "Vanilla imported forums" but when clicked in says:

"Sorry, but the forum you are currently viewing does not contain any child forums."

I had to do the following:

Rebuild each cache
Recount & rebuild all

Then the above error went away for me. I'm not 100% clear why yet, as the merge system is meant to do both of the above.

luisalvarado commented 3 years ago

Would you like me to send you the credentials for you to see it yourself?

euantorano commented 3 years ago

Would you like me to send you the credentials for you to see it yourself?

Sure, might be a good idea. If you give me Admin permissions then I can try fix it too 😄

luisalvarado commented 3 years ago

Thank you, I will email you everything. Thank you

luisalvarado commented 3 years ago

Hi @euantorano I emailed you a couple of days ago.

euantorano commented 3 years ago

Hi @euantorano I emailed you a couple of days ago.

Great, thanks. I'll take a look as soon as I get a chance.

luisalvarado commented 3 years ago

Just to update that this still an issue. @euantorano has worked hard on it, but the way that vanilla works is:

They give you an SQL file every month (New SQL file to download from their site).
This would then be taken to the mybb merger and hopefully worked from start to end so that the end result shows similar to the vanilla forum.

Currently, the posts and categories are the issue, so basically the mybb merger fails for vanilla forums.

mybb / merge-system

Latest Vanilla Forum importing issues (Forum has no parents, threads or posts) #264