search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 34 forks source link

Vanilla merge - forums merge error #266

Closed euantorano closed 3 years ago

euantorano commented 3 years ago

While debugging #264, I ran into the following error:

SQL Error:
1366 - Incorrect integer value: '' for column `mybb`.`mybb_forums`.`pid` at row 1
Query:
UPDATE mybb_forums SET `pid`='', `parentlist`='37' WHERE fid='37' LIMIT 1
euantorano commented 3 years ago

Note: I got around this by adding the following chunk of code here:

            if (empty($forum['updatefid'])) {
                continue;
            }
luisalvarado commented 3 years ago

Another one, you are on fire. How can I test this

euantorano commented 3 years ago

Another one, you are on fire. How can I test this

I need to open another PR with the above code modification in, which I'll do along with a fix for #268 this week.