search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 34 forks source link

Vanilla import: PM import warning - invalid argument supplied for foreach() #268

Closed euantorano closed 3 years ago

euantorano commented 3 years ago

When importing PMs in the Vanilla forum module, the following warnings are shown:

Screenshot 2021-01-24 at 17 03 02
euantorano commented 3 years ago

Note: this relates to the following block of code:

https://github.com/mybb/merge-system/blob/feature/boards/vanilla/privatemessages.php#L45:L48

The format of the recips column in the data I have is as follows:

a:3:{i:0;s:1:"2";i:1;s:1:"4";i:2;s:2:"12";}
luisalvarado commented 3 years ago

Thank you buddy, awesome news here. How can I test this.

euantorano commented 3 years ago

Thank you buddy, awesome news here. How can I test this.

At the moment, I don't have a proper fix in place - as these are just warnings, the merge system continues and simply doesn't import PMs. That's obviously not ideal though. I need to retry this and work out a fix, I suspect it's not a problem happening for every single PM, but rather just some of them.