search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 34 forks source link

Vanilla import: warning importing avatars when AWS S3 is used for storage #269

Closed euantorano closed 3 years ago

euantorano commented 3 years ago

When AWS S3 is used for avatar storage, the avatar import module for Vanilla throws the following warnings:

Screenshot 2021-01-24 at 17 07 52

This is due to S3 uploads having the form s3://uploads/userpics/....

luisalvarado commented 3 years ago

Awesome news yesss!!! Thank you buddy. So how is this fixed?

euantorano commented 3 years ago

Awesome news yesss!!! Thank you buddy. So how is this fixed?

There are 2 options - one of which is easy, the other not so easy:

  1. Ignore avatars as part of the merge that have s3:// at the start (this is the easy option, but not ideal).
  2. Add a step that runs before the merge that downloads all avatars from S3 to a local folder. This will require some additional details like S3 URL and such to work (this is the harder option, but could be done manually outside of the merge system with a bash script, which would be my preference short term).
luisalvarado commented 3 years ago

Could the other Vanilla issues be merged without this one, so we could start testing with our data site?

euantorano commented 3 years ago

Sure, that sounds like a good compromise. I'll try get that done ASAP and get a demo up for you.

luisalvarado commented 3 years ago

Sure, that sounds like a good compromise. I'll try get that done ASAP and get a demo up for you.

please thank you Euan. We do not worry about the images since we could maybe create an API that can handle that later one, everything else that you have worked on has so much value for the import process to go smoothly and avoid the bullying from Vanilla.

Thank you buddy.

luisalvarado commented 3 years ago

Hi buddy any updates @euantorano