search

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.
Other
34 stars 34 forks source link

Added support for PDO & fixed PHP 8 errors #274

Closed bram1000 closed 2 years ago

bram1000 commented 2 years ago

There will still be a lot of warnings in PHP 8 but at least the merge system will be functional. The thing I worry about the most is the following line of code: function error($type, $message, $file=null, $line=0, $allow_output=false)

I set the default to false because the merge system has so many warnings that it becomes unusable because it obscures the view, temporary fix until the merge system has been rewritten?

euantorano commented 2 years ago

Wow, great work. I'll have a look through this today and post any feedback.

On Sat, 21 Aug 2021, at 02:13, Bram wrote:

There will still be a lot of warnings in PHP 8 but at least the merge system will be functional. The thing I worry about the most is the following line of code: function error($type, $message, $file=null, $line=0, $allow_output=false)

I set the default to false because the merge system has so many warnings that it becomes unusable because it obscures the view, temporary fix until the merge system has been rewritten?

You can view, comment on, or merge this pull request online at:

https://github.com/mybb/merge-system/pull/274

Commit Summary

bram1000 commented 2 years ago

@euantorano Any updates about this pull request?

yuliu commented 2 years ago

OK, I'll try to update your PR.

yuliu commented 2 years ago

There will still be a lot of warnings in PHP 8 but at least the merge system will be functional. The thing I worry about the most is the following line of code: function error($type, $message, $file=null, $line=0, $allow_output=false)

I set the default to false because the merge system has so many warnings that it becomes unusable because it obscures the view, temporary fix until the merge system has been rewritten?

We're seeing so many PHP warnings when using the merge system on PHP 8 because these warnings are waiting to be fixed and we want it to show all the warnings (#255). And I changed the default value of $allow_output to true, which is the default behavior of MyBB's error reporting functionality, because we want the merge system to output as many errors/warnings as possible so that we could help users with their imports.

yuliu commented 2 years ago

There's one more place to change but I'll leave it in another PR to avoid conflicts. https://github.com/mybb/merge-system/blob/21175e369ef28b80e991dabffc8850efb5017079/resources/functions.php#L319