Fixes #224 make `CREATE TABLE` and `ALTER TABLE` compatible with PostgreSQL and SQLite

mybb / merge-system

The MyBB Merge System allows for easy merging of an existing forum (be it MyBB or another forum software) into a MyBB 1.8.x forum.

Other

34 stars 34 forks source link

Fixes #224 make `CREATE TABLE` and `ALTER TABLE` compatible with PostgreSQL and SQLite #280

Closed yuliu closed 2 years ago

yuliu commented 2 years ago

Fixes #224.

Note: MyBB installation on SQLite database may still fail to merge other forums due to some very old quirks of manipulating ALTER TABLE SQL syntax in MyBB core.

yuliu commented 2 years ago

To repeatedly test this PR in MyBB installed on a PostgreSQL database, one might need MyBB to have https://github.com/mybb/mybb/pull/4503.

yuliu commented 2 years ago

SQLite's add/drop column function doesn't work with recent MyBB and thus I can't test the PR with a MyBB installed on a SQLite database, though it should work as expected. I'll merge it and try to figure out the SQLite issues later.